custom binding with click and clickBubble does not work?

[julienaubert]

I have a few cases where I have <a> which I want to be regular clicks, so I wrote a custom binder.

There seems to be an inconsistency how click vs event works though. My first attempt did not work:

ko.bindingHandlers.domClick = {
    init: function(element, valueAccessor, allBindings, deprecated, bindingContext) {
        ko.applyBindingAccessorsToNode(element, {
            click: function() {return true;},
            clickBubble: function() {return false;}
        }, bindingContext);
    }
}

The 'clickBubble' is not available in the allBindings() in the event.init for some reason (and so it assumes bubble is false). If I instead use 'event', then it works:

ko.bindingHandlers.domClick = {
    init: function(element, valueAccessor, allBindings, deprecated, bindingContext) {
        ko.applyBindingAccessorsToNode(element, {
            event: function() {return { 'click': function() {return true;}}},
            clickBubble: function() {return false;}
        }, bindingContext);
    }
}

I am not sure as to why, seems odd?

[mbest]

The first example needs to change to this:

ko.bindingHandlers.domClick = {
    init: function(element, valueAccessor, allBindings, deprecated, bindingContext) {
        ko.applyBindingAccessorsToNode(element, {
            click: function() {return function() {return true;}; },
            clickBubble: function() {return false;}
        }, bindingContext);
    }
}