Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor agreement for contributors #1833

Open
brianmhunt opened this issue Jul 23, 2015 · 5 comments
Open

Add contributor agreement for contributors #1833

brianmhunt opened this issue Jul 23, 2015 · 5 comments
Milestone

Comments

@brianmhunt
Copy link
Member

Alternatives include https://cla-assistant.io/

Note clahub/clahub#111

@knockout-triage-server
Copy link

I originally implemented the CLA using clahub but reverted when I
discovered that it required getting permissions to do all kinds of things
using your GitHub account (for example, it could read/write arbitrary repos
as you).

Do you know if they have changed it to not require anything beyond
verifying your identity?

@brianmhunt
Copy link
Member Author

I think those levels of permissions are part and parcel with those integrations, it seems.

The way to protect ones private repos would be to set up an organization, which gives more granular access i.e. you can specifically disable all third party access until explicitly granted for each integration.

@SteveSanderson
Copy link
Contributor

It wasn't just that clahub required giving it permission to the Knockout repos. It also required everyone who used it to sign the CLA to give it full access to their GitHub accounts. That seems completely mad to me - I know I'd certainly not grant it such permissions - I don't think signing any CLA would be important enough to justify doing that. Maybe this has changed.

@brianmhunt
Copy link
Member Author

@SteveSanderson Oh yes, I see. That is madness. I like the concept, but yes... madness. :) Will try to look into it and post back here.

@brianmhunt brianmhunt changed the title Add contributor agreement to clahub.com Add contributor agreement to the process Aug 13, 2015
@brianmhunt brianmhunt changed the title Add contributor agreement to the process Add contributor agreement for contributors Aug 13, 2015
@brianmhunt
Copy link
Member Author

Incidentally, this came to mind because I went through a similar process when contributing a PR to Karma via karma-runner/karma#1513

@mbest mbest modified the milestone: Not assigned Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants