Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery.clean() is not a documented, public API #503

Closed
rwaldron opened this issue May 29, 2012 · 4 comments
Closed

jQuery.clean() is not a documented, public API #503

rwaldron opened this issue May 29, 2012 · 4 comments

Comments

@rwaldron
Copy link

As the title explains, jQuery.clean() is not a documented, public API and should not be relied on by any third party code -- we're not bound to maintaining the signature or any of the behaviour. Reliance on such APIs makes it incredibly difficult for us to fix problems or remove old, unnecessary code.

@mbest
Copy link
Member

mbest commented May 29, 2012

Thanks for the information. Do you have a suggestion for how we can replace jQuery.clean()?

@rwaldron
Copy link
Author

I would recommend removing the condition here: https://github.com/SteveSanderson/knockout/blob/master/src/utils.domManipulation.js#L56-60

And just using the custom implementation.

Also, this should be resolved by 1.8 release this summer: https://github.com/SteveSanderson/knockout/blob/master/src/utils.domManipulation.js#L41-43

@mbest
Copy link
Member

mbest commented Dec 15, 2012

@SteveSanderson - Is there any harm in taking out the jQuery.clean reference? Maybe we can do this in 3.0.0 if it's a breaking change.

@mbest
Copy link
Member

mbest commented Jan 15, 2013

Good that jQuery now supports a real interface for this (see #796). Closing.

@mbest mbest closed this as completed Jan 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants