Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a monorepo #17

Closed
brianmhunt opened this issue May 7, 2017 · 3 comments
Closed

Move to a monorepo #17

brianmhunt opened this issue May 7, 2017 · 3 comments

Comments

@brianmhunt
Copy link
Member

I had separated out the KO scripts into packages to make absolutely certain that the relationships between the packages was logical and minimal (i.e. I couldn't make lazy cross-references 😉 ).

Now that we've got a fairly logical ES6 hierarchy, and I think the essential build tools are set, it might be time to bring it all together.

The most common way to combine multiple packages like this appears to be a monorepo with lerna.

Never having gone down the monorepo path, I have some skepticism, but it's evidently got quite a lot of mindshare.

I wanted to post this issue for two reasons:

  1. Invite any feedback – any experience with the monorepo design/tools (e.g. lerna); and
  2. So nobody wonders all the repos are being deleted.

Any thoughts: @knockout/core @knockout/extended

Cheers 🍻

@mbest
Copy link
Member

mbest commented May 8, 2017

I'm in favor of a monorepo. I tried working with the tko repositories and found it quite cumbersome (and resource heavy).

@brianmhunt
Copy link
Member Author

brianmhunt commented May 8, 2017

To try and preserve as much history from the other repositories as possible, as part of this move I (effectively) rebased to a new/orphan branch master.

Some action will be necessary to pull/push new changes as expected. The easiest is re-cloning git@github.com:knockout/tko, otherwise it's a bit of mucking around.

Sorry for the inconvenience.

@brianmhunt
Copy link
Member Author

This is complete now, all tests passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants