Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different mechanism for custom textures in different minecraft versions #2

Closed
knokko opened this issue Jan 4, 2021 · 1 comment
Closed

Use different mechanism for custom textures in different minecraft versions #2

knokko opened this issue Jan 4, 2021 · 1 comment
Labels
enhancement New feature or request Expected difficulty: hard This will be hard and/or time-consuming to fix or implement
Projects
v10

Comments

@knokko
Copy link
Owner

knokko commented Jan 4, 2021

Currently, the plug-in will always use the Unbreakable + Damage trick to assign textures to custom items. When I started this plug-in, this was the only trick available, but new tricks were introduced in later minecraft versions. The current trick has some limitations, so upgrading would be nice for the users that use minecraft 1.13 or later. However, I don't want to just drop the current system because that would stop the plug-in from supporting minecraft 1.12.

The best solution would be to use different texture tricks in different minecraft versions.
@knokko knokko added enhancement New feature or request Expected difficulty: medium This will take some time and effort to fix or implement labels Jan 4, 2021
@knokko knokko mentioned this issue Jan 4, 2021
Open
@knokko knokko added Expected difficulty: hard This will be hard and/or time-consuming to fix or implement and removed Expected difficulty: medium This will take some time and effort to fix or implement labels Jan 18, 2021
@knokko knokko added this to To do in v10 Feb 3, 2022
@knokko knokko moved this from To do to In progress in v10 Feb 26, 2022
@knokko
Copy link
Owner Author

knokko commented Feb 27, 2022

Note to myself: don't forget to let the ItemUpdater handle transitions between them.

@knokko knokko moved this from In progress to Done in v10 Mar 4, 2022
@knokko knokko closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Expected difficulty: hard This will be hard and/or time-consuming to fix or implement
Projects
No open projects
v10
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knokko