Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell version check doesn't fail the task #28

Closed
mattanknol opened this issue Dec 19, 2019 · 6 comments
Closed

PowerShell version check doesn't fail the task #28

mattanknol opened this issue Dec 19, 2019 · 6 comments

Comments

@mattanknol
Copy link

As I commented in #27 (comment), the PS4.0 check broke the task for us (we sincerely hope you will revert this check!). Unfortunately the task doesn't error, but just gives a message and signals DevOps that it executed successful. See also the provided screenshot.

I suspect that (besides the error you write) you need to exit the task with an error code or something equivalent.

image

@knom
Copy link
Owner

knom commented Dec 19, 2019

Ah! Right.. thanks for spotting this!
I will update accordingly..

@mattanknol
Copy link
Author

As I asked in the comment #27 (comment), is lowering the check to PS3.0 also an option?

@knom
Copy link
Owner

knom commented Dec 19, 2019

Yes.. I just checked and it would work in PS3..
So I will rewrite..

@mattanknol
Copy link
Author

Thanks, any idea how long it will take until these changes are also 'available' on Azure DevOps?

@knom
Copy link
Owner

knom commented Dec 20, 2019

This is fixed in https://github.com/knom/vsts-regex-tasks/releases/tag/3.3.11
Which is available in Marketplace as of now!

@knom knom closed this as completed Dec 20, 2019
@mattanknol
Copy link
Author

Thanks for the quick work!
Our pipeline works again, so we are very happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants