knope silently fails to create release tag?

[MarquessV]

Hello! 😄

Recently, we've had some issues where knope fails to create a new git tag for a release. It appears to succeed, and generates the right commit and CHANGELOG entry, but the associated tag doesn't get created. From my understanding of the documentation it shouldn't be possible to successfully create a release without an associated git tag if you have GitHub setup properly.

This seems to happen intermittently on full releases, but never on pre-releases. We're using 0.7.1, and this is our knope.toml. The CI logs for these releases look normal and don't indicate any error. Happy to try and provide other diagnostics!

[dbanty]

It looks like your release workflow is missing the Release step (your prerelease workflow has it), so I'd expect the release workflow to never create a GitHub release (and therefore tag). I also suggest combining prerelease and release and using the --prerelease-label CLI option instead, to avoid issues like this in the future.

I opened rigetti/quil-rs#256 as an example (that GHA syntax might not be right, though)

[dbanty]

Oh, as a manual test, you can also run with --dry-run and it should tell you if it's going to create a GitHub Release. I like to do this automatically in CI so I can see what will happen next time I run a full release.

[MarquessV]

Doh, sorry about that. I was under the impression it had been working and misread the release workflow. I'll be using that --prerelease-label trick to simplify our workflows in other repos as well.