Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add confirm step type #978

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alex-way
Copy link
Contributor

@alex-way alex-way commented Mar 28, 2024

Closes #953

Provides functionality to allow prompts with confirmation before proceeding with the remainder of the workflow.

Dry-run functionality will simply print a message saying that it will prompt the users with the message provided in the knope.toml configuration.

  • Refactor confirm function to make testing easier
  • Add unit tests
  • Add documentation for confirm step type
  • Add auto-confirmation functionality (-y in the CLI)
  • Add documentation for -y flag

@alex-way alex-way marked this pull request as draft March 28, 2024 09:00
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for knope canceled.

Name Link
🔨 Latest commit 245408f
🔍 Latest deploy log https://app.netlify.com/sites/knope/deploys/663a8e01efa2690008b534e0

@alex-way
Copy link
Contributor Author

@dbanty Would it be wise to wait until #920 is merged until adding any unit tests into this one? The core functionality is there, just tests currently missing

@dbanty
Copy link
Member

dbanty commented Mar 28, 2024

#920 might be in limbo for a little bit—it's powering a new feature for the GitHub bot, but I don't have time to finish the feature for a few weeks 😓.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Prompt Step type
2 participants