Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailChimp integration is broken #295

Closed
cdriehuys opened this issue Mar 15, 2018 · 2 comments
Closed

MailChimp integration is broken #295

cdriehuys opened this issue Mar 15, 2018 · 2 comments

Comments

@cdriehuys
Copy link
Member

Bug Report

Our current implementation of the MailChimp integration is broken. The biggest issue is that when registering, a user is saved before their email address is created. When the integration tries to look up the user's email address, we get an error.

To fix the integration, it should probably be tied to email instances instead of users.

@cdriehuys
Copy link
Member Author

Tying the integration to emails instead of users would result in each user possibly being subscribed multiple times. We just need to check for the existence of their primary email address before we use it.

@cdriehuys
Copy link
Member Author

Whoops, managed to misunderstand my own comment...

The integration's signal should definitely be tied to the saving of email addresses rather than users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant