fix(ie): Only check if input when not IE (#71)

* Only check if input when not IE * Move to deps
knownasilya · Apr 13, 2017 · 69af664 · 69af664
1 parent 3934eef
commit 69af664
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/addon/components/x-toggle-switch/component.js b/addon/components/x-toggle-switch/component.js
@@ -1,5 +1,6 @@
 import Component from 'ember-component';
 import computed from 'ember-computed';
+import service from 'ember-service/inject';
 import layout from './template';
 
 export default Component.extend({
@@ -8,14 +9,17 @@ export default Component.extend({
   classNames: ['x-toggle-container'],
   classNameBindings: ['size', 'disabled:x-toggle-container-disabled', 'value:x-toggle-container-checked'],
 
+  browserChecker: service(),
+
   themeClass: computed('theme', function() {
     return `x-toggle-${this.get('theme') || 'default'}`;
   }),
 
   click(e) {
     const clickedElement = this.$(e.target);
+    const isIE = this.get('browserChecker.isExplorer');
 
-    if (clickedElement.is('input')) {
+    if (isIE || clickedElement.is('input')) {
       this.sendToggle(!this.get('value'));
     }
   }

diff --git a/package.json b/package.json
@@ -23,6 +23,7 @@
     "release": "standard-version"
   },
   "dependencies": {
+    "ember-browser-checker": "0.0.6",
     "ember-cli-babel": "^5.1.7",
     "ember-cli-htmlbars": "^1.1.1",
     "ember-runtime-enumerable-includes-polyfill": "^1.0.1"

diff --git a/yarn.lock b/yarn.lock
@@ -2075,6 +2075,12 @@ ember-ajax@^2.4.1:
   dependencies:
     ember-cli-babel "^5.1.5"
 
+ember-browser-checker@0.0.6:
+  version "0.0.6"
+  resolved "https://registry.npmjs.org/ember-browser-checker/-/ember-browser-checker-0.0.6.tgz#cd0fd75f5bd7098041df69e3a0c7adb8633801be"
+  dependencies:
+    ember-cli-babel "^5.1.6"
+
 ember-cli-babel@^5.1.10, ember-cli-babel@^5.1.3, ember-cli-babel@^5.1.5, ember-cli-babel@^5.1.6, ember-cli-babel@^5.1.7, ember-cli-babel@^5.2.1:
   version "5.2.4"
   resolved "https://registry.npmjs.org/ember-cli-babel/-/ember-cli-babel-5.2.4.tgz#5ce4f46b08ed6f6d21e878619fb689719d6e8e13"
@@ -5228,7 +5234,7 @@ read@1, read@~1.0.1, read@~1.0.7:
   dependencies:
     mute-stream "~0.0.4"
 
-"readable-stream@1 || 2", readable-stream@^2.0.2, readable-stream@~2.0.5:
+"readable-stream@1 || 2", readable-stream@^2, readable-stream@^2.0.2, readable-stream@~2.0.5:
   version "2.0.6"
   resolved "https://registry.npmjs.org/readable-stream/-/readable-stream-2.0.6.tgz#8f90341e68a53ccc928788dacfcd11b36eb9b78e"
   dependencies:
@@ -5239,7 +5245,7 @@ read@1, read@~1.0.1, read@~1.0.7:
     string_decoder "~0.10.x"
     util-deprecate "~1.0.1"
 
-readable-stream@^2, "readable-stream@^2.0.0 || ^1.1.13", readable-stream@^2.1.4, readable-stream@^2.1.5, readable-stream@^2.2.2:
+"readable-stream@^2.0.0 || ^1.1.13", readable-stream@^2.1.4, readable-stream@^2.1.5, readable-stream@^2.2.2:
   version "2.2.6"
   resolved "https://registry.npmjs.org/readable-stream/-/readable-stream-2.2.6.tgz#8b43aed76e71483938d12a8d46c6cf1a00b1f816"
   dependencies: