A11Y error due to tabindex > 0

[Willibaur]

Thanks for this awesome addon.

Below you will see an A11Y error related, it was catched by ember-A11Y-testing it seems an easy one to fix on 👉 x-toggle/component.js

I'm happy to create a PR if you agree this should be tabindex: '0'.

Thanks

[knownasilya]

Could probably just remove the tabindex all together and users can apply those as needed.

[Willibaur]

I'm not sure, as a general A11Y rule, it should be tabindex: 0, so what about to set it to that value by default within the addon, but give the option to the user to modify as required @knownasilya like we do with offLabel property ?

[knownasilya]

The user can already set it, e.g. {{x-toggle tabindex='0'}}

[knownasilya]

I'll change it to '0'

[Willibaur]

Thanks for the fix @knownasilya

[knownasilya]

Released in 5.3.1