Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ember-component-is-visible deprecation (3.15) #128

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

scottkidder
Copy link
Contributor

Address this deprecation. All tests are passing but it's possible this has somehow subtly altered behavior.

@scottkidder scottkidder changed the title fix: address the ember-component-is-visible deperecation (3.15) fix: address the ember-component-is-visible deprecation (3.15) Dec 20, 2019
@scottkidder scottkidder changed the title fix: address the ember-component-is-visible deprecation (3.15) Fix ember-component-is-visible deprecation (3.15) Dec 20, 2019
@knownasilya
Copy link
Owner

Ah that's silly, because we aren't actually using the deprecated feature because we have our own isVisible defined. Will look at the logic to see if anything might be affected. Thanks for submitting.

@knownasilya knownasilya merged commit c1ad3ba into knownasilya:master Dec 20, 2019
@petervtzand
Copy link

Hi. Can this be pushed to NVM?

@knownasilya
Copy link
Owner

@petervtzand it's actually not 100% the same functionality, since it keeps the wrapping element. So I have to convert the element to a tagless one to make it the same. Will try to get this this week.

@knownasilya
Copy link
Owner

Give v6.0.1 a try :D

@petervtzand
Copy link

@knownasilya Thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants