-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hammerjs with ember-gesture-modifiers, fixes #138 #139
Replace hammerjs with ember-gesture-modifiers, fixes #138 #139
Conversation
Just checked locally what is happening and everything seems to be working as intended except that it is mirrored (drag left, toggle right). One not of importance here is that currently ember-gesture-modifiers only supports touch events, not pointer events, so it will only work on touch screens right now (or Chrome's responsive mode). I have started working on pointer event support in ember-gesture-modifiers, but did not finish it yet. If we want to keep ember-toggle exactly like it is we'll need the pointer event support first before merging it. |
Ah! This makes sense. 馃槵 I'm not currently using @nickschot Ping in in the PR when you have it for more 馃憖. |
I've made a branch with PointerEvents support which should make this branch work. nickschot/ember-gesture-modifiers#16 Would be great if we could try the branch before I do a release. You'll need to pass a |
Tests are running. Thanks for working on this @nickschot |
@nickschot do the way we test a pan need to be updated? |
Oh yes! You probably used something like my pan helper? You'll need to let it create a PointerEvent now instead of a TouchEvent. The PR has updated helpers. edit: I don't know how those jquery (?) triggered pan events in the test work? Seems to be a hammerjs thing? |
Yeah those events were hammerjs specific I believe. |
@nickschot could you export the pan helper as part of |
Done!
|
@nickschot waiting on tests, but I think you can merge that pointer events PR. |
@knownasilya great! I'll prepare a release then. |
What do you guys think about semver for this change. It seems like a patch, but people could be using hammerjs from this addon. Thoughts? |
I've tried to tackle #138 and
ember-gesture-modifiers
don't work for me: the action does not fire.I tried debugging the modifier a bit and discovered that the addEventListeners hook does fire but actions below do not.
@nickschot, can you please have a look and see what I'm missing? 馃檹