Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower case v causes error in the parser #108

Closed
timelyportfolio opened this issue Jan 20, 2015 · 8 comments
Closed

lower case v causes error in the parser #108

timelyportfolio opened this issue Jan 20, 2015 · 8 comments

Comments

@timelyportfolio
Copy link

It appears v anywhere inside the diagram spec will cause the parser to fail. As an example,
graph LR; v; fails while graph LR; V; works just fine.

ref rich-iannone/DiagrammeR#47

@timelyportfolio timelyportfolio changed the title Av causes error in the parser lower case v causes error in the parser Jan 20, 2015
@timelyportfolio
Copy link
Author

updated to say any "v" in spec causes an error

knsv added a commit that referenced this issue Jan 20, 2015
@knsv
Copy link
Collaborator

knsv commented Jan 20, 2015

Fixed the problem, it will be included in the next release. Root cause was that the character v is also used for direction down

@timelyportfolio
Copy link
Author

I see the fix and the test passes. However, this graph LR; v; still does not work while this does graph TD; V-->a[v]. Should I expect this or just know that v is a reserved character?

@knsv
Copy link
Collaborator

knsv commented Jan 25, 2015

Missed this one or I would have included this in 0.3.3.

I have added v as a valid for ids so with the next release this will work. Perhaps we should sum things up and do bigger fix for the characters. Right now its one at a time when they pop up.

@vijay40
Copy link
Contributor

vijay40 commented Jan 29, 2015

The wiki should be updated to reflect that direction of graph can also be specified by >,<,^,v.

@knsv
Copy link
Collaborator

knsv commented Mar 1, 2015

This si working in the mermaid version 0.4.0. Closing this issue. Reopen if this till is a problem.

@knsv knsv closed this as completed Mar 1, 2015
@timelyportfolio
Copy link
Author

Sorry to be a pain, but...

graph TD; v-->a; still does not work
graph TD; V[v]-->a; does

Not really a huge problem, but v as reserved and not available as an id should probably be documented.

@knsv
Copy link
Collaborator

knsv commented Mar 10, 2015

I agree, will look at it. It is a "keyword" but perhaps the grammar could allow this keyword.

mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
…ontawesome_stylesheet

Updated fontawesome stylesheet link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants