New line at the end of SVG file

[joelrfcosta]

GitHub review is warning that there should be an empty line at the end of document:

Is this reasonable, or just does not make sense on this document type?

[nicksp]

@joelrfcosta This is reasonable imo. The message is displayed because otherwise there is no way to tell the difference between a file where there is a newline at the end and one where is not. Diff has to output a newline anyway, or the result would be harder to read or process automatically.
And make sure, we have setting in .editorconfig that force us to use newlines.

This is a good habit to have newlines at the end of files due to 1 and 2 btw

[knsv]

I am guessing that the use case is a svg generated by the cli with svg option set. Correct?

[joelrfcosta]

Correct! 👍

On 30 Oct 2016, at 16:27, Knut Sveidqvist notifications@github.com wrote:

I am guessing that the use case is a svg generated by the cli with svg option set. Correct?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[knsv]

Found the right place in the code to fix this but unsure about how to handle this in a platform independent way.

[knsv]

Closed by release 7.0.0, please reopen if issues remain.