Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Enhancement proposal: not fail --version / --help if phantomjs isn't installed #71

Closed
sudodoki opened this issue Dec 27, 2014 · 3 comments
Closed

[cli] Enhancement proposal: not fail --version / --help if phantomjs isn't installed #71

sudodoki opened this issue Dec 27, 2014 · 3 comments

Comments

@sudodoki
Copy link

Right now, if you don't have phantomjs available in your path, help & version commands will output only error message. I would suggest adding output of original command as well.
@sudodoki
Copy link
Author

Would suggest assigning this to me for time being

@knsv
Copy link
Collaborator

knsv commented Dec 27, 2014

@fardog, your thoughts on this?

@sudodoki sudodoki changed the title Enhancement proposal: not fail --version / --help if phantomjs isn't installed [cli] Enhancement proposal: not fail --version / --help if phantomjs isn't installed Dec 28, 2014
@fardog
Copy link
Contributor

fardog commented Dec 28, 2014

@knsv yeah; it was done in this way mostly for expedience, but I can see this being a useful thing. I'll put together a PR shortly.

@knsv knsv closed this as completed in 7bcbe6f Dec 28, 2014
knsv added a commit that referenced this issue Dec 28, 2014
@knsv
Merge pull request #75 from fardog/enhancement-71
9f904da 
Show help and version even if phantom isn't present. Fixes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sudodoki @fardog @knsv