Require d3 directly to better support Node usage #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knsv
added a commit
that referenced
this pull request
Jan 20, 2015
Require d3 directly to better support Node usage
|
Excellent! I had a hunch that this needed to be done. |
|
I'm trying to use mermaid with webpack but proxyquire is causing problems thlorenz/proxyquire#62 Is there anyway to avoid using proxyquire? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node consumers should only have to run
require("mermaid"), but the current implementation assumes that thed3global has been set up beforehand.This change brings
d3in line with howdagre-d3is handled internally, i.e. thed3dependency is required directly.In order for the existing
sequenceRenderertests to continue working, I had to introduce proxyquire so that a mockd3could be injected.