The option of gantt for the spaces for the section names. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good stuff! |
|
Thanks for merging 😄 |
|
This is now part of release 6.0.0. Thx again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, thank you for the nice library.
According to mermaidAPI.js,
sidePaddingof the gantt enables to specifythe space allocated for the section name to the left of the activities., but the total width of the gantt seems to be changed whensidePaddingis changed.This PR enables to specify the spaces for the section name without affecting the total with of the gantt.
There is one thing to note.
I change the option name from
sidePaddingtoleftPaddingbecause theleftPaddingmeans only the left side of spaces for the section names in contrast with thatsidePaddingmeans the both side of spaces on the gantt.I don't particular about the name issue above, so I'm grad to hear your opinion.
Thanks.