Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the method isStaticSection public #9

Closed
nitriques opened this issue Jun 26, 2011 · 8 comments
Closed

Make the method isStaticSection public #9

nitriques opened this issue Jun 26, 2011 · 8 comments

Comments

@nitriques
Copy link

Hi! I wrote an extension that adds button to the backend of Symphony. Since these buttons should not be displayed in a static section, it could be nice to use your method instead of the copy/paste I made..

The purpose of this is to permit you to modify your logic as when and how a section is declared static, while keeping other extensions from crashing if your logic changes.

What do you think ?

@nitriques
Copy link
Author

Is there any chance I get a response ?

@nitriques
Copy link
Author

:(

@nitriques
Copy link
Author

@knupska: I can take over the maintenance of this project if you do not want to do it anymore...

@vlad-ghita
Copy link
Contributor

@nitriques

This extension is maintained by @rainerborene. You should simply fork it, make the change, pull request and even notice on the forum.

@knupska
Copy link
Owner

knupska commented Jul 2, 2011

Sorry guys, yes, please let @rainerborene know.

I'm not particularily good at using Git myself, and haven't had the time available to maintain this extension in a very long time.

@rainerborene
Copy link
Collaborator

That's perfectly possible, @nitriques. Could you fork this repository and make this change?

@rainerborene
Copy link
Collaborator

Done. 94de060

@nitriques
Copy link
Author

@everybody:

I am a bit confused here... What to you want me to do ? Nothing since @knupska's code is up-to-date ? Thanks by the way! Did you changed the version number ?

And anther question: How should we change repros on the Symphony Website when the "official" one changes? Should we published it as a new ext or update the old one ?

I always go on the extension page and to my search there so I think it must be up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants