You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding this "feature" to Testcontainers (Java) Neo4j right now and noticed that the property is only valid in 5.3+.
This means that every other 5.x before needs to get the server.config.strict_validation.enabled flag set to false.
(NEO4J_server_config_strict__validation_enabled in Neo4j Docker env).
Also including some kind of warning that
a) the password is shorter than the default and
b) server config does not get validated
might be good.
Referring to this line:
Obviously I have no idea how to move this Item into a list of items, otherwise I would have taken the chance to publish a new PR :D
Edit: Reflecting my idea: It might be better to add another configuration method to set the server config into the "non-strict" mode. Cleaner API. This way the user does this intentionally.
Older images will not start and the new method points out exactly this in the docs.
The text was updated successfully, but these errors were encountered:
In #11 the with_version method validates the version and the call might fail.
I can see adding similar validation to with_password to return an Err when the size is less than 8. Maybe we only need to do that on 5.3, but always can be a good start. We would no longer need to mess around with the config.
I wanted to add with_config in the future, because I saw it on the Java module, and then users can do their config crimes if they need to.
Adding this "feature" to Testcontainers (Java) Neo4j right now and noticed that the property is only valid in 5.3+.
This means that every other 5.x before needs to get the
server.config.strict_validation.enabled
flag set to false.(
NEO4J_server_config_strict__validation_enabled
in Neo4j Docker env).Also including some kind of warning that
a) the password is shorter than the default and
b) server config does not get validated
might be good.
Referring to this line:
neo4j-testcontainers-rs/src/lib.rs
Lines 390 to 392 in 1ee7bda
Obviously I have no idea how to move this
Item
into a list of items, otherwise I would have taken the chance to publish a new PR :DEdit: Reflecting my idea: It might be better to add another configuration method to set the server config into the "non-strict" mode. Cleaner API. This way the user does this intentionally.
Older images will not start and the new method points out exactly this in the docs.
The text was updated successfully, but these errors were encountered: