Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every example *and* test is reassigning request body to response body #147

Closed
SampsonCrowley opened this issue May 3, 2022 · 1 comment
Assignees

Comments

@SampsonCrowley
Copy link

SampsonCrowley commented May 3, 2022

Why is this the default example in every case to just blindly reassign the body back to body and send it back instead of having even one single example of how to use the params within the parsed request body? (I assume it's an object or array)

I'm honestly confusued on this design decision outside of testing. Testing makes sense up to a point. is this module not even a request parser? is it a response formatter??

@3imed-jaberi 3imed-jaberi self-assigned this Mar 31, 2023
@3imed-jaberi
Copy link
Member

@SampsonCrowley, through the example we try to ensure/show the body parsing.
If you want an additional example, feel free to open a PR or put your request in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants