Binary response support (application/octet-stream)

[stepankuzmin]

Hi there! It seems that cash doesn't support binary responses (like application/octet-stream).

Eg. I'm trying to response with pbf like

ctx.body = Buffer.from(geobuf.encode(geojson, new Pbf()));

And getting

Error: Place koa-cache below any compression middleware.;

My response headers are:

HTTP/1.1 200 OK
Vary: Accept-Encoding
Content-Type: application/octet-stream
Content-Length: 2227
Content-Encoding: identity
ETag: "8b3-CASiLhVb9Ldvy7npP1sNNQ"
Date: Fri, 09 Dec 2016 14:40:13 GMT
Connection: keep-alive

[lbeschastny]

Hi.

This exception should occur when you register some compression middleware after registering cash, i.e.:

app.use(cash()) // WRONG!
app.use(compress())

cash should support binary responses, but underlying cache implementation should allow storing Buffer objects.

[stepankuzmin]

Oh, right. I've somehow missed it. Thanks!