Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding response.originalLength property #86

Closed
ianstormtaylor opened this issue Nov 19, 2018 · 2 comments
Closed

consider adding response.originalLength property #86

ianstormtaylor opened this issue Nov 19, 2018 · 2 comments

Comments

@ianstormtaylor
Copy link

It would be nice if this added a response.originalLength property to make it easy to send trace information about the "real" response length. This would mimic the existing request.originalUrl that Koa maintains.

@jonathanong
Copy link
Member

the primary issue with this is that we don't know the length of streams and finding out means we have to buffer the entire body. might be better done in a downstream middleware

@jonathanong
Copy link
Member

actually yeah, should be done downstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants