Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add coding style check #89

Closed
bananaappletw opened this issue Oct 9, 2016 · 3 comments · Fixed by #93
Closed

[Suggestion] Add coding style check #89

bananaappletw opened this issue Oct 9, 2016 · 3 comments · Fixed by #93

Comments

@bananaappletw
Copy link
Contributor

Maybe adding coding styles check for this repo could make the example codes coherence.
Just some suggestion.
See also:
https://github.com/koajs/koa/blob/v2.x/.eslintrc.yml
https://github.com/feross/standard

@bananaappletw
Copy link
Contributor Author

@hemanth What do you think about this?
In general, most of rules could be accepted by js programmer.
But there is still a fierce debate about semicolon.
I don't have bias against these two different coding style.
One is with semicolon, the other isn't.
Although, it required better understanding about statements to write code without semicolon.
But mostly, code with semicolon could avoid more errors than one without it.
I think that's why koa is using one with semicolon.

@hemanth
Copy link
Member

hemanth commented Oct 12, 2016

Makes absolute sense, please add them.

@bananaappletw
Copy link
Contributor Author

Sure!!!
But I have some homework to do this week.
Maybe next week, I will have time to implement it.
Thanks for the reply. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants