Using node-jsonwebtoken error message ?

[jinwyp]

Suggestion for using node-jsonwebtoken module error message

see https://github.com/auth0/node-jsonwebtoken errors:
TokenExpiredError and JsonWebTokenError

change file index.js line 51

 if (!passthrough) {
                const msg = debug ? e.message : 'Authentication Error';
                ctx.throw(401, msg);
            }

change to

 if (!passthrough) {
                const msg = debug ? e.message : e.message || 'Authentication Error';
                ctx.throw(401, msg {name : e.name || 'UnauthorizedError'});
            }

[olegmdev]

+1

[sdd]

Hi,

Sorry for the delayed reply, I've been on holiday. What is the motivation behind this? You can set opts.debug to true to get the original e.message as the thrown error message. I'm potentially open to this if you can provide good enough reasons why this would be useful enough to potentially risk breaking anyone's apps who depend on those messages being what they are now.

[clintmod]

It seems a bit unusual to have to pass a debug flag to learn that the token has expired. It also seems pretty important to know that the token has expired so that the api consumer can refresh it.

[sdd]

I agree - it is unusual. But still, if the problem can be solved by using option.debug = true, then changing the behaviour to make it less unusual would affect more people than just requiring users who need the message to set options.debug to true.