Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Version 2.x introduced the URL object, which is not compatible with Node versions below 10. #1808

Closed
3 tasks
kkdev163 opened this issue Apr 11, 2024 · 0 comments · Fixed by #1809
Closed
3 tasks

[fix] Version 2.x introduced the URL object, which is not compatible with Node versions below 10. #1808

kkdev163 opened this issue Apr 11, 2024 · 0 comments · Fixed by #1809
Assignees
@fengmk2
Labels
bug

Comments

@kkdev163
Copy link

kkdev163 commented Apr 11, 2024 •
edited

Describe the bug

Node.js version: 8.11.2

OS version:

Description:

Actual behavior

2024-04-11 14:25:48,740[v2][music-puzzle-admin][music-puzzle-admin][195926][traceId][spanId][uid][0:0][ERROR][mug] - [-/10.200.xxx.xxx/-/58ms GET /puzzle/tag/module/48] nodejs.ReferenceError: URL is not defined

    at Object.redirect (/home/appops/music-puzzle-admin/music-puzzle-admin_online/default/approot/node_modules/koa/lib/response.js:266:7)

koa/lib/response.js

Line 266 in ddbff30

url = new URL(url).toString();

Expected behavior

Code to reproduce

Checklist

  • I have searched through GitHub issues for similar issues.
  • I have completely read through the README and documentation.
  • I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.
@kkdev163 kkdev163 added the bug label Apr 11, 2024
@kkdev163 kkdev163 changed the title [fix] Version 2.15.2 introduced the URL object, which is not compatible with Node versions below 10. [fix] Version 2.x introduced the URL object, which is not compatible with Node versions below 10. Apr 11, 2024
@fengmk2 fengmk2 self-assigned this Apr 11, 2024
fengmk2 added a commit that referenced this issue Apr 11, 2024
@fengmk2
fix: require URL from 'url' module
3cc7f49 
closes #1808
@fengmk2 fengmk2 mentioned this issue Apr 11, 2024
Merged
fengmk2 added a commit that referenced this issue Apr 11, 2024
@fengmk2
fix: require URL from 'url' module (#1809)
1fad597 
closes #1808
@fengmk2 fengmk2 linked a pull request Apr 11, 2024 that will close this issue
fix: require URL from 'url' module #1809
Merged
@fengmk2 fengmk2 closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengmk2 fengmk2

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: require URL from 'url' module koajs/koa
2 participants
@fengmk2 @kkdev163