New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove qs dependency #38
Comments
meh most people expect nesting support, you can still use it just like querystring |
oh, i intentionally don't use nesting support. i want to assume that all the parameters are strings - i hate type checking. plus, there are things like doing i would argue that it should be moved out of core just like everything else, but it's not a big deal since i can just overwrite it. |
you can't do either of those with qs, and we dont coerce types |
closing for now. I don't personally use nesting much at all either but it's one of the most top downloaded modules on npm so lots of people definitely do. We can revisit if any big issues come up |
actually, changed my mind, for now let's do the reverse, wait for people to complain haha. Worth noting that you don't really need to typecheck though, that's the great thing about no using callbacks, we can finally just let things break without all the burden |
oh. that's true too. i'm just paranoid with errors being thrown around in node. |
i personally don't like qs. would be nice if you removed it as a dep and used the native
querystring
module in core, then moved qs to a separate repo.The text was updated successfully, but these errors were encountered: