Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider domain support (optional?) #42

Closed
tj opened this issue Aug 28, 2013 · 1 comment
Closed

consider domain support (optional?) #42

tj opened this issue Aug 28, 2013 · 1 comment

Comments

@tj
Copy link
Member

tj commented Aug 28, 2013

seems like we can't really wrap just one stream so we may want to consider this, knocks a good 1000rps off but eh. seems a little tricky to do with middleware since we have to terminate it lower, similar issue to the compress middleware

@tj tj closed this as completed Aug 28, 2013
@tj tj reopened this Aug 28, 2013
@jonathanong
Copy link
Member

i don't see the point of domains with koa since now i get ridiculously long error traces that now give me too much information. plus, right now i find it annoying since it catches things like syntax errors or references errors and it takes me a little longer to debug vs. just crashing.

either way, it should be optional and separate from core.

@tj tj closed this as completed Nov 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants