New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should app.listen also return a promise? #45
Comments
What would that accomplish? |
well, in Node.js server.listen() also take a |
I'd like to defer that sort of boot logic, ideally you'd get everything ready and then .listen() for connections, but thankfully most database drivers buffer requests and so on so usually .listen() at the bottom without a callback is just fine |
@visionmedia why not just remove |
I find it useful, just need to be certain that it's not going to change and turn into some giant wtf |
https://github.com/koajs/koa/blob/master/lib/application.js#L62 currently returning
server.listen()
, thoughts?The text was updated successfully, but these errors were encountered: