Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider delegating to ctx.request / ctx.response #52

Closed
tj opened this issue Sep 14, 2013 · 2 comments
Closed

consider delegating to ctx.request / ctx.response #52

tj opened this issue Sep 14, 2013 · 2 comments

Comments

@tj
Copy link
Member

tj commented Sep 14, 2013

In general I don't like this for the average use-case and "hot" methods, but I do prefer this.request.etag to this.get('ETag'), this.request.length, this.response.length, this.response.header etc, but the common cases we have would delegate: this.body = foo == this.response.body = foo. something to think about

@jonathanong
Copy link
Member

couldn't sleep so i got a branch going... so tedious.

@tj
Copy link
Member Author

tj commented Oct 25, 2013

haha yeah man, lots of shuffling of the tests n shit :( not fun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants