Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ducktype stream checks #54

Closed
tj opened this issue Sep 14, 2013 · 2 comments
Closed

ducktype stream checks #54

tj opened this issue Sep 14, 2013 · 2 comments

Comments

@tj
Copy link
Member

tj commented Sep 14, 2013

instanceof Stream is lame
@jonathanong
Copy link
Member

i don't mind doing something like if (stream._readableState) since it would also block people from making makeshift streams (ie emit their own events)

@tj
Copy link
Member Author

tj commented Nov 12, 2013

makes me a little sad that node's stream interface doesn't allow for makeshift streams, inheriting in js is pretty lame but i guess that's true they would just break otherwise with the current stuff

@tj tj closed this as completed Nov 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tj @jonathanong