Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad argument handling #20

Closed
qraynaud opened this issue May 18, 2014 · 2 comments
Closed

bad argument handling #20

qraynaud opened this issue May 18, 2014 · 2 comments

Comments

@qraynaud
Copy link

In index.js, in the first line of the staticCAche function, there is:

if (typeof dir === 'object') {
  options = dir
  files = options
  dir = null
}

this is wrong because options is lost before being copied to files. this should be:

if (typeof dir === 'object') {
  files = options
  options = dir
  dir = null
}
@dead-horse
Copy link
Member

PR ?

@qraynaud
Copy link
Author

I don't have time to do this right now. I'll post here when I start if noone does it before me :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants