Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: detect return values other than 0-225 (like strings) in functions when used via variables #1060

Open
2 tasks done
mika opened this issue Nov 23, 2017 · 0 comments
Open
2 tasks done

Comments

@mika
Copy link

mika commented Nov 23, 2017

For new checks and feature suggestions

Here's a snippet or screenshot that shows the problem:

#!/bin/bash
foo() {
  local file="/usr/bin/foo"
  return "$file"
}
foo

Here's what shellcheck currently says:

No issues detected!

Here's what I wanted or expected to see:

SC2152: Can only return 0-255. Other data should be written to stdout.

JFTR, shellcheck detects it when used without a variable but a plain string already:

#!/bin/bash
foo() {
  return bar                                                                                                                                                                                                                                 
}
foo

This is reported as SC2152: Can only return 0-255. Other data should be written to stdout..

Thanks for shellcheck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant