Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint against case where a variable name could be a flag #2612

Open
2 tasks done
KSXGitHub opened this issue Oct 23, 2022 · 0 comments
Open
2 tasks done

Lint against case where a variable name could be a flag #2612

KSXGitHub opened this issue Oct 23, 2022 · 0 comments

Comments

@KSXGitHub
Copy link

KSXGitHub commented Oct 23, 2022

For new checks and feature suggestions

Here's a snippet or screenshot that shows the problem:

#!/bin/bash
set -o errexit -o pipefail -o nounset

printf '%s' 'Enter file name to delete... '
read -r filename
rm "$filename"

Here's what shellcheck currently says:

Nothing.

Here's what I wanted or expected to see:

Warns that $filename in the rm command could be a flag, and suggests inserting -- in between rm and $filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant