Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[empty] filter does not contain field with only HTML-Tags #769

Closed
rimace opened this issue Mar 5, 2020 · 2 comments
Closed

[empty] filter does not contain field with only HTML-Tags #769

rimace opened this issue Mar 5, 2020 · 2 comments

Comments

@rimace
Copy link

rimace commented Mar 5, 2020

Describe the bug
The [empty] filter now filters out columns that contain nothing visible to the user, only empty HTML-Tags.

Reproduction steps:
Steps to reproduce the behavior:

  1. Use a table with a column that contains only an empty
    tag or any other tag
  2. Type "[empty]" (without "") in the filter.

Expected behavior
The row should still be seen. As the column does not contain anything for the user, it should not be filtered out when using [empty].

Observed behavior:
The row gets filtered and is not shown anymore.

TableFilter version: 0.6.109
Browser and version: Firefox 68 ESR and 73
OS and version: Fedora 31
Device: Dell Latitude

Additional information/context:
It worked as expected with version 0.6.47.

  • Problem started happening recently, didn't happen in an older version of TableFilter: Yes, if yes 0.6.47
  • Problem can be reliably reproduced, doesn't happen randomly: Yes
@rimace rimace added the bug label Mar 5, 2020
@rimace
Copy link
Author

rimace commented Mar 9, 2020

I found out it was pull request #626 (release with version 0.6.50) that introduces the bug but fixed #625 .
Reading the PR, I think it is more of a definition than a bug, if invisible tags count as content.
Maybe there is a way to find out if the tag is visible to the user? This would solve my problem and still contains the feature from that PR :)

@koalyptus koalyptus added this to In Progress in Refactoring/tech debt/bugs Jun 16, 2020
@koalyptus koalyptus moved this from In Progress to In QA in Refactoring/tech debt/bugs Jun 16, 2020
@koalyptus
Copy link
Owner

koalyptus commented Jun 16, 2020

Hi @rimace,
starting from v0.7.2 the empty operator should satisfy the scenario you described in this ticket, main change being here:
https://github.com/koalyptus/TableFilter/pull/784/files#diff-692e87a92facd3d8d9d526be6777b6bfR1878

Let me know how it goes.
Cheers

@rimace rimace closed this as completed Sep 1, 2020
@koalyptus koalyptus moved this from In QA to DONE in Refactoring/tech debt/bugs Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants