Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_feature_names_out for encoders #29

Closed
CarloLepelaars opened this issue Nov 16, 2022 · 1 comment
Closed

get_feature_names_out for encoders #29

CarloLepelaars opened this issue Nov 16, 2022 · 1 comment

Comments

@CarloLepelaars
Copy link
Contributor

I would be happy to implement get_feature_names_out for all the Embetter objects. I will implement them by just adding a new method (without a Mixin).

@koaning
Copy link
Owner

koaning commented Nov 17, 2022

I might want to put that on hold for a bit, partially because I don't have a super clear roadmap in what I do/not want to cover in this library. Maybe I want to have sparse embeddings, or 2d/3d embeddings as well? In which case I might have tools that are a bit of an anti-pattern.

Maybe later, but at this point the project needs to mature before I consider such features.

@koaning koaning closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants