You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed on reviewing this PR that SingleInteractiveChart does not check if the inputs make sense with regards to the dataframe that is passed in. We don't want to create an extra SingleInteractiveChart under the InteractiveCharts object because this causes side effects (unneeded json data).
Let's add some ValueErrors there.
The text was updated successfully, but these errors were encountered:
I noticed on reviewing this PR that
SingleInteractiveChart
does not check if the inputs make sense with regards to the dataframe that is passed in. We don't want to create an extraSingleInteractiveChart
under theInteractiveCharts
object because this causes side effects (unneeded json data).Let's add some
ValueErrors
there.The text was updated successfully, but these errors were encountered: