Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decomposition.umap_reconstruction.UMAPOutlierDetection #653

Open
Tracked by #596
FBruzzesi opened this issue Apr 26, 2024 · 4 comments
Open
Tracked by #596

decomposition.umap_reconstruction.UMAPOutlierDetection #653

FBruzzesi opened this issue Apr 26, 2024 · 4 comments
Assignees
Labels
documentation We might describe something better good first issue Good for newcomers

Comments

@FBruzzesi
Copy link
Collaborator

No description provided.

@FBruzzesi
Copy link
Collaborator Author

@anopsy created separate issues to link directly PRs

@anopsy
Copy link
Contributor

anopsy commented Apr 27, 2024

Thanks! I'll also repeat my question:

what would be a more elegant example - applying them on ndrrays or a dataframe?

I noticed that some examples in sklego are based on dataframes and some on numpy arrays or ndarrays. I noticed that scikit-learn mostly uses arrays in their examples. Let me know what do you think, maybe I'm overthinking that

@FBruzzesi
Copy link
Collaborator Author

I would suggest to use arrays as well wherever possible. Dataframes may be more interpretable but they are more in the direction of skrub philosophy

@anopsy
Copy link
Contributor

anopsy commented Apr 27, 2024

Coolio! That's more of an idea for the future, but when all examples are added, maybe it would be good to base them all on arrays then. Just sayin'

@anopsy anopsy mentioned this issue Apr 27, 2024
2 tasks
@FBruzzesi FBruzzesi added good first issue Good for newcomers documentation We might describe something better labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation We might describe something better good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants