Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add manual dark mode support #91

Closed
dev-afzalansari opened this issue Nov 19, 2022 · 1 comment · Fixed by #93
Closed

Feat: Add manual dark mode support #91

dev-afzalansari opened this issue Nov 19, 2022 · 1 comment · Fixed by #93

Comments

@dev-afzalansari
Copy link
Contributor

While reading the source code I played around it a little bit and added dark mode support to the panel. I think it will be more convenient to let users choose the theme of the panel on their own instead of only depending on system's theme.

color-mode-demo.webm

Currently swr-devtools-panel depends on system's preference to enable dark mode manual dark mode has option for that too.

@koba04, should i open a PR for this.
@koba04
Copy link
Owner

koba04 commented Nov 19, 2022

@dev-afzalansari That looks amazing!!! 👍 👍

@dev-afzalansari dev-afzalansari mentioned this issue Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: add manual dark mode support dev-afzalansari/swr-devtools
2 participants
@koba04 @dev-afzalansari