Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the HiddenSelect component from Select for compatibility with form libraries #84

Closed
fabien-ml opened this issue Jan 27, 2023 · 4 comments
Milestone

Comments

@fabien-ml
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When using form libraries (ex: https://modularforms.dev/) some props need to be passed to the native select element.

Describe the solution you'd like
Expose the HiddenSelect component from Select.

Additional context
This will be a breaking change since the user will need to manually add this component when creating a select.

@teenjuna
Copy link

Hi there! I encountered this issue with felte: when I changed value with select, the form state wasn't updated. Seems like this is the problem.

However, I wanted to say that I've also encountered the same problem with RadioGroup component. Can it be the same underlying issue?

@fabien-ml
Copy link
Collaborator Author

Hi, with RadioGroup you already have access to each native input element: RadioGroup.ItemInput

@teenjuna
Copy link

Sorry, my bad, I used the component but forgot to pass the required props.

@fabien-ml fabien-ml added this to the v0.7.0 milestone Feb 1, 2023
@fabien-ml
Copy link
Collaborator Author

fixed in v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Published
Development

No branches or pull requests

2 participants