Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing data-readonly attribute on RadioGroup.ItemControl and RadioGroup.ItemIndicator #205

Closed
jcmonnin opened this issue May 2, 2023 · 0 comments

Comments

@jcmonnin
Copy link

jcmonnin commented May 2, 2023

The missing data-readonly attributes on the RadioGroup.ItemControl and RadioGroup.ItemIndicator make it cumbersome to apply a different style when the radio group is read only.

This probably applies to different components and attributes as well.

From discord chat:

The radiogroup doesn't set data-readonly on the children. There are a few properties in the dataset of the context that are missing > compared to checkbox. Is this deliberate?
I was trying to style a readonly radio button, and couldn't do it the same way than on the checkbox.

fabienml — Today at 9:27 AM
Unlike checkbox, a radio button doesn't live on its own, it is always in a radio group, so it's the radio group that is read only. (
You can style it with some descendant selector but it will be cumbersome. Please open an issue for me to add the needed data-*, > i'm sure there are others than data-readonly that i've not added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant