Field error binding should not be hardcoded

[vladvel]

Field error handler binds error to 'version' field of domain class in any case. I have some problems with i18n of error message, because I can not use i18n label for domain class. Also I can not use custom error message code or message for specific domain. In some cases error binding to version field is not needed, when specific handler is used.
I offer to add a config option to disable this behavior if needed, or disable it when onConflict handler is being used.

[nobeans]

It sounds good. there are three ways:

1. using a default message (already supported)
2. using a custom message code and args and a default message (args and a default message can be omitted)
3. not using a field error

you need 2 and 3, don't you?

[nobeans]

These behave as same as before, binding the default field error with hard-coded message code:

myDomain.withOptimisticLock { domain ->
    domain.save()
}

OR

myDomain.withOptimisticLock { domain ->
    domain.save()
}.onConflict { domain, cause ->  // defaultErrorBinding:true by default
    ...
}

OR

myDomain.withOptimisticLock { domain ->
    domain.save()
}.onConflict(defaultErrorBinding: true) { domain, cause -> // explicitly specified
    ...
}

You can specified a parameter "defaultErrorBinding" with false to avoid binding default field error:

myDomain.withOptimisticLock { domain ->
    domain.save()
}.onConflict(defaultErrorBinding: false) { domain, cause ->
    domain.errors.rejectValue("your.code", [123] as Object[], "default!!")
    ...
}

How about it?

[vladvel]

It is great! But can you also add configuration parameter to specify default behavior in Config.groovy? It will be setted to "true" by default (for backward compatibility) and used if parameter defaultErrorBinding in onConflict() handler is omitted.

[nobeans]

It seems good to be able to specify default value in Config.groovy. okay, I'll try it.

[nobeans]

I implemented that on a feature branch. Could you confirm the sample code as test cases?

https://github.com/kobo/grails-domain-locking/blob/issues/3/test/integration/org/jggug/kobo/domainlocking/OptimisticLockingDynamicMethodSpec.groovy#L153-L210

If you like it, I'll merged it to master branch.

[vladvel]

The test cases are correct for my request. Thank you for this work! I am waiting for it to update my project.

[nobeans]

Merged into master. v0.4 will be released asap. Thank you!

[nobeans]

v0.4 released. enjoy!