Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for stdin(stdio::null)? #28

Closed
whatmatrix opened this issue Dec 21, 2022 · 4 comments · Fixed by #29
Closed

Reason for stdin(stdio::null)? #28

whatmatrix opened this issue Dec 21, 2022 · 4 comments · Fixed by #29

Comments

@whatmatrix
Copy link

whatmatrix commented Dec 21, 2022

I have a command-line app that I wishes to use PGO and BOLT. It takes a few inputs from stdin at the startup. It works well with cargo run.

cargo pgo seems to be overriding stdin by passing stdio::null().

Is it necessary for cargo pgo functionalities? cargo pgo run obviously works differently than cargo run due to this.

@Kobzol
Copy link
Owner

Kobzol commented Dec 22, 2022

Hi, good point. I think that I did this only out of habit, but for cargo pgo run it doesn't make sense. Can you please try if this PR fixes your problem?

$ cargo install --git https://github.com/kobzol/cargo-pgo --branch pass-stdin

@whatmatrix
Copy link
Author

Hi,

Thank you very much for being responsive! It works very well. I really appreciate your work!

@Kobzol
Copy link
Owner

Kobzol commented Dec 22, 2022

No problem! I'm glad that it helped. I will release a new version with the patch soon if there won't be any other changes in the meantime.

@Kobzol
Copy link
Owner

Kobzol commented Jan 16, 2023

Published 0.2.4 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants