Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional data support #19

Closed
fracek opened this issue Jul 6, 2020 · 2 comments
Closed

Optional data support #19

fracek opened this issue Jul 6, 2020 · 2 comments

Comments

@fracek
Copy link
Contributor

fracek commented Jul 6, 2020

Describe the feature

The standard supports optional types, I think this can be added by adding an implementation of the relevant traits for Option<T>.

I can work on a PR for this.
@kbartush
Copy link
Contributor

kbartush commented Jul 6, 2020

Generally I've been using unions with the 0 case as void for optional items. I believe they create the same XDR output as an optional item. Adding an actual Option would be much cleaner though.

@kbartush
Copy link
Contributor

kbartush commented Jul 7, 2020

Had a hiccup in the deployment, rather than manually fixing anything, I just cut a new release at v0.2.3 that has your changes. If there are any issues let me know.

@kbartush kbartush closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fracek @kbartush