Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect logic on zero CRC #11

Closed
flooduk opened this issue Oct 14, 2017 · 1 comment
Closed

incorrect logic on zero CRC #11

flooduk opened this issue Oct 14, 2017 · 1 comment
Assignees
Labels
Projects
Milestone

Comments

@flooduk
Copy link

flooduk commented Oct 14, 2017

if crc16 checksum is zero, exception thrown, but checksum is correct
logs:
INFO: Frame sent: F70400000010E550
INFO: Frame recv: F70420FFE2FFF0030C008C008404C004CC043A0007000C013D000C00040A3400020016F816
INFO: Frame sent: F70400000010E550
INFO: Frame recv: F70420FFE2FFF0030E008B008404C004CC043A0007000C013D000C00040A3400020016AD3D
INFO: Frame sent: F70400000010E550
INFO: Frame recv: F70420FFE3FFF10315008B008304C004CC043A0007000C0142000C00040A34000200160000
com.invertor.modbus.exception.ModbusChecksumException: checksum error: received 0, calculated 0
at com.invertor.modbus.net.stream.InputStreamRTU.frameCheck(InputStreamRTU.java:44)
at com.invertor.modbus.net.transport.ModbusTransportSerial.read(ModbusTransportSerial.java:50)
at com.invertor.modbus.net.transport.ModbusTransport.readMessage(ModbusTransport.java:60)
at com.invertor.modbus.net.transport.ModbusTransport.readResponse(ModbusTransport.java:55)
at com.invertor.modbus.ModbusMaster.readResponse(ModbusMaster.java:110)
at com.invertor.modbus.ModbusMaster.processRequest(ModbusMaster.java:135)
at com.invertor.modbus.ModbusMaster.readInputRegisters(ModbusMaster.java:208)

@kochedykov
Copy link
Owner

Fixed, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
JLibModbus
Awaiting triage
Development

No branches or pull requests

2 participants