Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash loading patches for booty shifter #13

Closed
squinkylabs opened this issue Oct 1, 2021 · 2 comments
Closed

crash loading patches for booty shifter #13

squinkylabs opened this issue Oct 1, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@squinkylabs
Copy link
Contributor

It looks like the json is (now) deserialized before the widget is created. Looks like bad code on my part. There is a widget called PopupMenuParamWidget that attempts to do this better, don't know if that would help.

I inserted a booty shifter.
turned the knobs
quit Rack
ran rack again
boom!

Thread 1 received signal SIGSEGV, Segmentation fault.
0x00007fffc55e3d05 in BootyModule::dataFromJson (this=0x19cfcf326b0,
    rootJ=<optimized out>) at src/BootyModule.cpp:102
102                     WARN("existing text = %s", rangeChoice->text.c_str());
(gdb) bt
#0  0x00007fffc55e3d05 in BootyModule::dataFromJson (this=0x19cfcf326b0,
    rootJ=<optimized out>) at src/BootyModule.cpp:102
#1  0x00007ff80a967f9b in rack::engine::Engine::fromJson (this=0x19cfb05de00,
    rootJ=rootJ@entry=0x19cfcf1b070) at src/engine/Engine.cpp:1266
#2  0x00007ff80a92926c in rack::patch::Manager::fromJson (
    this=this@entry=0x19cfcded400, rootJ=rootJ@entry=0x19cfcf1b070)
    at src/patch.cpp:457
#3  0x00007ff80a9294a1 in rack::patch::Manager::loadAutosave (
    this=0x19cfcded400) at src/patch.cpp:319
    ```
@kockie69 kockie69 added this to To Do in V2 migration Oct 1, 2021
@kockie69 kockie69 added the bug Something isn't working label Oct 1, 2021
@kockie69 kockie69 moved this from To Do to In progress in V2 migration Oct 1, 2021
@kockie69 kockie69 moved this from In progress to Done in V2 migration Oct 1, 2021
@kockie69
Copy link
Owner

kockie69 commented Oct 1, 2021

This one can be tested as it is solved. Moved a shared variable to module

@squinkylabs
Copy link
Contributor Author

yeah, seems fine now.

@kockie69 kockie69 moved this from Done to Released in V2 migration Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants