Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for netdata #41

Closed
wants to merge 1 commit into from
Closed

Add support for netdata #41

wants to merge 1 commit into from

Conversation

vlvkobal
Copy link

This PR adds the option -N to ioping to allow it output statistics in a netdata friendly format. The fping and netdata interaction was organized in the same way a long time ago. A corresponding PR was made for netdata.
image

arkamar added a commit to arkamar/gentoo that referenced this pull request Oct 24, 2019
netdata USE applies patch [1] necessary for netdata support.

[1] koct9i/ioping#41

Closes: https://bugs.gentoo.org/693596
Package-Manager: Portage-2.3.76, Repoman-2.3.16
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Dec 11, 2019
netdata USE applies patch [1] necessary for netdata support.

[1] koct9i/ioping#41

Closes: https://bugs.gentoo.org/693596
Package-Manager: Portage-2.3.76, Repoman-2.3.16
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
@Mic92
Copy link

Mic92 commented Mar 20, 2020

Has a merge conflict now.

@Mic92
Copy link

Mic92 commented Mar 20, 2020

Would it not be better to parse the json output in netdata?

@Mic92
Copy link

Mic92 commented Mar 20, 2020

$ ioping --json /dev/nvme0n1p1 | jq -r --stream "fromstream(1|truncate_stream(inputs)) | \"BEGIN 'ioping.\(.target.path)_\(.io.size)_\(.io.operation)_latency' \(.io.time)\n\""
BEGIN 'ioping./dev/nvme0n1p1_4096_read_latency' 29674022
BEGIN 'ioping./dev/nvme0n1p1_4096_read_latency' 30263366
BEGIN 'ioping./dev/nvme0n1p1_4096_read_latency' 248194
BEGIN 'ioping./dev/nvme0n1p1_4096_read_latency' 30365810
BEGIN 'ioping./dev/nvme0n1p1_4096_read_latency' 1116499

@Mic92
Copy link

Mic92 commented Mar 20, 2020

updated revision: e7b8184

@koct9i
Copy link
Owner

koct9i commented Mar 25, 2020

Yep, reading json output is ok.

I'm not so familiar with opensource monitoring solutions, but running separate ioping instance just to poke disk periodically seems dubious. This easily could be integrated into monitoring service as plugin or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants