Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EVM wallet connector #10284

Open
vikiival opened this issue May 13, 2024 · 7 comments · Fixed by #10354
Open

Make EVM wallet connector #10284

vikiival opened this issue May 13, 2024 · 7 comments · Fixed by #10354
Assignees
Labels
A-base build on base, L2 chain by Coinbase A-sidebar related to sidebars A-wallet related to wallet stuff design-request enhancement New feature or request evm p1 preventing everyone from using app

Comments

@vikiival
Copy link
Member

Is your feature request related to a problem?

I would like to connect my EVM wallets:

  • Metamask
  • Talisman
  • Coinbase wallet

To the Koda.

Describe the solution you would like

I would like to see a tabs DOT / EVM where default will be determined by active chain

You can obtain it by chainProperties.vm

vm: ChainVM // vm stands for vitrual machine

Screenshot 2024-05-13 at 12 40 09

Impl

amazing @brano-hozza hacked EVM login last weekend so code can be reused

https://github.com/Retiazky/shuffle-dao

Describe alternatives you have considered

We have considered Web3Modal - #10137
But that does not work

Screenshots

No response

Are there opened related issues?

No response

@vikiival vikiival added enhancement New feature or request p1 preventing everyone from using app A-wallet related to wallet stuff design-request evm A-sidebar related to sidebars A-base build on base, L2 chain by Coinbase labels May 13, 2024
@hassnian
Copy link
Contributor

hassnian commented May 18, 2024

cc @exezbcz 👀

@vikiival
Copy link
Member Author

Exez is OOO until end of may.

Proposed solution is already described above

@exezbcz
Copy link
Member

exezbcz commented May 19, 2024

letsgo with this
image

not sure if this solution is super optimal but don't want to block

@exezbcz
Copy link
Member

exezbcz commented May 19, 2024

when switched to evm, lets show metamask, rabby, rainbow, walletconnect

@vikiival
Copy link
Member Author

or @exezbcz why cannot we use web3modal for evm only?

@hassnian
Copy link
Contributor

hassnian commented May 20, 2024

or @exezbcz why cannot we use web3modal for evm only?

waiting for this to start

@exezbcz
Copy link
Member

exezbcz commented May 23, 2024

@hassnian sorry for the late response, yup sure, lets use web3modal

  • its not optimal solution, but IMO good for start
  • change the "substrate" to "polkadot"
  • once evm is clicked, it switches the tab and displays login with web3modal

once you connect evm wallet, you can only see evm network, polkadot is disabled

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-base build on base, L2 chain by Coinbase A-sidebar related to sidebars A-wallet related to wallet stuff design-request enhancement New feature or request evm p1 preventing everyone from using app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants