Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge preloader component for transactions with facts preloader #1632

Closed
yangwao opened this issue Dec 29, 2021 · 2 comments
Closed

Merge preloader component for transactions with facts preloader #1632

yangwao opened this issue Dec 29, 2021 · 2 comments
Labels
$ ~<50usd A-nuxt p4 affecting less than 10% of app v2.2

Comments

@yangwao
Copy link
Member

yangwao commented Dec 29, 2021

Is there a possibility to merge these two into one component?

Like till user waits for confirmation it can read that fact and we have their attention tho till then, rather than looking on "2/3"

image

@yangwao yangwao added $ ~<50usd p4 affecting less than 10% of app A-nuxt labels Dec 29, 2021
@kkukelka
Copy link
Member

huh, doesn't it use the same <Loader /> component?

@yangwao yangwao added the v2.2 label Jan 8, 2022
@yangwao
Copy link
Member Author

yangwao commented Apr 8, 2022

I think this is already being done

@yangwao yangwao closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-nuxt p4 affecting less than 10% of app v2.2
Projects
Development

No branches or pull requests

2 participants