Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use <kbd> tag in KeyboardShortcuts component #2467

Closed
roiLeo opened this issue Mar 1, 2022 · 2 comments · Fixed by #2473
Closed

Use <kbd> tag in KeyboardShortcuts component #2467

roiLeo opened this issue Mar 1, 2022 · 2 comments · Fixed by #2473
Labels
$ ~<50usd accesibility Access by everyone regardless of disability is an essential aspect. good first issue as new commer, something you could start with p4 affecting less than 10% of app

Comments

@roiLeo
Copy link
Contributor

roiLeo commented Mar 1, 2022 •
edited
Loading

For good semantic pratice and accesibility, I'd like to use the html tag <kbd> (The Keyboard Input element) in KeyboardShortcuts component
@roiLeo roiLeo added accesibility Access by everyone regardless of disability is an essential aspect. p4 affecting less than 10% of app labels Mar 1, 2022
@yangwao yangwao added the $ ~<50usd label Mar 1, 2022
@roiLeo roiLeo added the good first issue as new commer, something you could start with label Mar 1, 2022
@zhengow
Copy link
Contributor

zhengow commented Mar 1, 2022

I'll check this

@zhengow zhengow mentioned this issue Mar 1, 2022
Merged
17 tasks
@yangwao
Copy link
Member

yangwao commented Mar 1, 2022

pay 100 usd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd accesibility Access by everyone regardless of disability is an essential aspect. good first issue as new commer, something you could start with p4 affecting less than 10% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue_2467：Use <kbd> tag in KeyboardShortcuts component
3 participants
@yangwao @roiLeo @zhengow